Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [merchantapi] new module for merchantapi #9810

Closed
wants to merge 2 commits into from
Closed

feat: [merchantapi] new module for merchantapi #9810

wants to merge 2 commits into from

Conversation

mpeddada1
Copy link
Contributor 

python3.9 generation/new_client/new-client.py generate \
--api_shortname=merchantapi \
--proto-path=google/shopping/merchant/inventories \
--name-pretty="Merchant API" \
--product-docs="https://developers.google.com/merchant/api" \
--api-description="Programmatically manage your Merchant Center accounts." \
--distribution-name="com.google.shopping:google-shopping-merchant-inventories"

@snippet-bot
Copy link

snippet-bot bot commented Sep 8, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 30 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo
Copy link
Member

suztomo commented Sep 8, 2023

I think "com.google.shopping" will fail the release.

@mpeddada1 mpeddada1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 11, 2023
@mpeddada1
Copy link
Contributor Author

Adding do-not-merge label due to same concern as described in #9811 (comment)

@mpeddada1
Copy link
Contributor Author

Closing in favor of #9885

@mpeddada1 mpeddada1 closed this Sep 26, 2023
@mpeddada1 mpeddada1 deleted the new_module_java-merchantapi branch September 26, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo Awaiting requested review from suztomo

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@alicejli alicejli Awaiting requested review from alicejli

Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @suztomo